[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 28 21:18:40 PDT 2021


tmsriram added a comment.

In D99487#2724702 <https://reviews.llvm.org/D99487#2724702>, @modimo wrote:

> Agree with @MaskRay I'd like to see a holistics plan/RFC on all the pieces that are needed to get this functionality. The functionality here is only tested when exceptions are actually propagated which is not common in LLVM test suite. You'll want to run and likely write very specific tests stressing the test matrix here of BBS + MFS + EH. Given all that, a larger plan that details how we can be confident that all the pieces have been accounted for and will be well tested is (IMO) imperative in getting this change reviewed and accepted.

Since this (the test matrix) is already done for ELF, would it be complete if the author added equivalent tests for COFF?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99487/new/

https://reviews.llvm.org/D99487



More information about the llvm-commits mailing list