[PATCH] D101335: [ASan][Darwin] Fix `TestCases/Darwin/init_for_dlopen.cpp` when running in a standalone build.
Julian Lettner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 28 15:05:57 PDT 2021
yln added a comment.
In D101335#2723210 <https://reviews.llvm.org/D101335#2723210>, @delcypher wrote:
> @yln Your comments have convinced me that I should try doing this a different way. I'll try the approach I outlined and I'll see how far I get.
Thanks for considering other options. For the record: I don't know what this other path looks like. If it's not workable, then yes, let's move forward.
I just felt that "fixing up a path for a specific substitution" (when there are other uses) and the sense that we need a warning when the two config options diverged may give rise to future problems or confusion.
> Changing this part of the CMake is incredibly risky because the way this code works differs between Apple and non-Apple platforms.
Maybe we can still guard the CMake change behind `if (APPLE)`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101335/new/
https://reviews.llvm.org/D101335
More information about the llvm-commits
mailing list