[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace
Eugene Zelenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 28 14:23:17 PDT 2021
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:25
+ Names) {
+ const auto FullName = "::" + Node.getQualifiedNameAsString();
+
----------------
Please don't use auto unless type is spelled explicitly in same statement or iterator.
================
Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:39
+
+ const auto FullNameTrimmedRef = StringRef(FullNameTrimmed);
+
----------------
Please don't use auto unless type is spelled explicitly in same statement or iterator.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101471/new/
https://reviews.llvm.org/D101471
More information about the llvm-commits
mailing list