[PATCH] D101284: [docs] Update the llvm/example section
Shivam Gupta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 28 12:40:21 PDT 2021
xgupta added a comment.
In D101284#2723554 <https://reviews.llvm.org/D101284#2723554>, @reames wrote:
> Minor optional suggestions, but LGTM to me too.
>
> @xgupta - I suggest avoiding both LGTMing and asking for another reviewer. Given LLVM is a single accept culture, this can be really confusing to new contributors. I suggest wording along the lines of "This seems good to me, but I'd like a second opinion before LGTMing. Maybe X and Y can confirm?" Alternatively, you could simply LGTM if you were comfortable with that. Another phrasing might be "LGTM, but please wait N days before submitting in case X or Y have additional comments".
Yes @reames, I agree, I will remember your suggestion from next time. I was just a little afraid that I am also not very experienced so giving only my acceptance to commit changes is a little risky(IMO). If next time I have confusion I only add an appropriate reviewer for that patch.
( Additional context here is that @pooja2299 is an Outreachy applicant and I am co-mentor for one project, so she adds me on every review so I will aware of her progress but I may not be the perfect reviewer for every patch)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101284/new/
https://reviews.llvm.org/D101284
More information about the llvm-commits
mailing list