[PATCH] D100945: [GreedyRA] Fix removeBackCopies to account empty copies

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 28 11:28:37 PDT 2021


reames added a comment.

This seems to assume that producing a dead copy is expected behavior.  Are you sure that the input form you describe is itself expected?  It seems a bit suspect.



================
Comment at: llvm/test/CodeGen/X86/statepoint-invoke-ra-remove-back-copies.mir:12
+
+  define void @hoge(i8 addrspace(1)* %arg) gc "statepoint-example" personality i32* ()* @widget {
+  bb:
----------------
Any chance this can be further reduced?  This looks really fragile.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100945/new/

https://reviews.llvm.org/D100945



More information about the llvm-commits mailing list