[PATCH] D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 28 11:16:28 PDT 2021
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
2 nits, LGTM otherwise.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:118
+ Runtime = 37,
+ Auto = 38, /**< auto */
+
----------------
Can we move all of the entries here and use `//< ...` comments maybe.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1255
const LocationDescription &Loc, CanonicalLoopInfo *CLI,
- InsertPointTy AllocaIP, bool NeedsBarrier, Value *Chunk) {
+ InsertPointTy AllocaIP, OMPScheduleType schedType, bool NeedsBarrier,
+ Value *Chunk) {
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101435/new/
https://reviews.llvm.org/D101435
More information about the llvm-commits
mailing list