[PATCH] D100897: [flang] Make 'team_number()' an intrinsic function

[Craig E Rasmussen via Phabricator via llvm-commits]

craig.rasmussen added inline comments.


================
Comment at: flang/include/flang/Common/default-kinds.h:59
   int defaultLogicalKind_{defaultIntegerKind_};
+  int derivedKind_{4};
 };
----------------
This was a guess.


================
Comment at: flang/unittests/Evaluate/intrinsics.cpp:159
   using Log4 = Type<TypeCategory::Logical, 4>;
+  // For testing team arguments
+  // using Team = Type<TypeCategory::Derived, 4>;
----------------
Team is for using a team actual argument in TestCall below at line 323, I don't know how to work this out.


================
Comment at: flang/unittests/Evaluate/intrinsics.cpp:321
+
+  // TODO: test TEAM argument
+  // TestCall{defaults, table, "team_number"}
----------------
Should be fixed or removed I assume.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100897/new/

https://reviews.llvm.org/D100897