[PATCH] D101458: [libc++] Do not copy the libc++abi headers into the libc++ build tree

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.

LGTM



================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:15
 
 macro(setup_abi_lib abidefines abishared abistatic abifiles abidirs)
   list(APPEND LIBCXX_COMPILE_FLAGS ${abidefines})
----------------
We should also consider inlining this macro, I don't think it's getting us anything and I always have to lookup what each argument does so at least in my experience it harms readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101458/new/

https://reviews.llvm.org/D101458