[PATCH] D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region

[Arnamoy B via Phabricator via llvm-commits]

arnamoy10 added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:305
+void OmpStructureChecker::CheckSIMDNest(const parser::OpenMPConstruct &c) {
+  // Check the following:
+  //  The only OpenMP constructs that can be encountered during execution of
----------------
kiranchandramohan wrote:
> Nit: A TODO for the loop construct.
Thanks, added.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:323
+                       std::get<parser::OmpBlockDirective>(beginBlockDir.t)};
+                   if (beginDir.v == llvm::omp::Directive::OMPD_ordered) {
+                     const auto &clauses{
----------------
kiranchandramohan wrote:
> Here ordered is a block-directive. But below it is a standalone directive. Is it parsed both ways?
Yes, according to [[ https://www.openmp.org/spec-html/5.0/openmpsu97.html | here ]], 
```
If the depend clause is specified, the ordered construct is a stand-alone directive.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99757/new/

https://reviews.llvm.org/D99757