[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

[David Candler via Phabricator via llvm-commits]

dcandler added inline comments.


================
Comment at: clang/lib/Basic/Targets/AArch64.h:36
+  bool HasSHA3;
+  bool HasSM4;
   bool HasUnaligned;
----------------
rsanthir.quic wrote:
> Would it make sense to further differentiate SM3 and SM4? I see that we differentiate between the two in arm_neon.td ("ARM_FEATURE_SM3" & "ARM_FEATURE_SM4") but we don't include this differentiation as flags (only HasSM4, +sm4 etc)
It might make more sense in the code to differentiate them, however the current feature and command line options align with GCC, so changing them would go beyond the scope of this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99079/new/

https://reviews.llvm.org/D99079