[PATCH] D99599: [NewPM] Add an option to dump pass structure

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added inline comments.


================
Comment at: llvm/include/llvm/IR/PassManagerImpl.h:77
 
-    PI.runAfterAnalysis(P, IR);
+    if (ID != PassInstrumentationAnalysis::ID())
+      PI.runAfterAnalysis(P, IR);
----------------
tejohnson wrote:
> evgeny777 wrote:
> > tejohnson wrote:
> > > What is this check needed for?
> > For runBeforeAnalysis and runAfterAnalysis to be in sync. See if block above:
> > ```
> > if (ID != PassInstrumentationAnalysis::ID()) {
> >       PI = getResult<PassInstrumentationAnalysis>(IR, ExtraArgs...);
> >       PI.runBeforeAnalysis(P, IR);
> > }
> > ```
> Sure I saw that above. But I guess my question is what is the practical effect of this change, i.e. why is it needed with your other changes in this patch when it wasn't needed before?
I felt this is right change, however I see no effect from it, so let's undo it for now


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99599/new/

https://reviews.llvm.org/D99599