[PATCH] D100956: [AIX][TLS] Add ASM portion changes to support TLSGD relocations to XCOFF objects
    Sean Fertile via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Apr 28 08:17:46 PDT 2021
    
    
  
sfertile accepted this revision as: sfertile.
sfertile added a comment.
This revision is now accepted and ready to land.
One minor nit but otherwise LGTM.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:528
+/// external symbol.
+static MCSymbol *createMCSymbolForTlsGetAddr(bool isAIX, MCContext &Ctx) {
+  if (isAIX)
----------------
Real minor nit: Its probably better the keep the helper as AIX only and then we don't need to worry about the boolean argument.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100956/new/
https://reviews.llvm.org/D100956
    
    
More information about the llvm-commits
mailing list