[PATCH] D101458: [libc++] Do not copy the libc++abi headers into the libc++ build tree

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 28 07:24:10 PDT 2021


ldionne created this revision.
ldionne added reviewers: phosek, thakis.
Herald added a subscriber: mgorny.
ldionne requested review of this revision.
Herald added projects: libc++, LLVM.
Herald added subscribers: llvm-commits, libcxx-commits.
Herald added a reviewer: libc++.

The only reasonable setup is for libc++abi to be responsible for
installing the libc++abi headers. Otherwise, we can potentially end
up with two copies of the libc++abi headers: one is installed by libc++abi
itself under <prefix>/include, and one is installed by libc++ under
<prefix>/include/c++/v1.

I expect this patch might break some people/bots with unexpected build
setups. We should discover who those are and see how their problems can
be solved, which I expect to be by building libc++abi explicitly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101458

Files:
  libcxx/cmake/Modules/HandleLibCXXABI.cmake
  libcxx/include/CMakeLists.txt
  libcxx/src/CMakeLists.txt
  llvm/utils/gn/secondary/libcxx/include/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101458.341195.patch
Type: text/x-patch
Size: 5430 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210428/edfa37c0/attachment.bin>


More information about the llvm-commits mailing list