[PATCH] D101440: [DSE] Eliminate store after calloc (PR50143)

[Florian Hahn via Phabricator via llvm-commits]

fhahn added reviewers: nikic, asbirlea.
fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:241
   if (onlyAccessesInaccessibleMem(MRB))
-    return ModRefInfo::NoModRef;
+    return isAllocLikeFn(Call, &TLI) ? ModRefInfo::Mod : ModRefInfo::NoModRef;
 
----------------
>From this workaround, it seems like how `inaccessiblememonly` is used for `calloc` does not completely match AA's interpretation. Are there other cases in the code base? I'm not sure if special casing `calloc` here is ideal. 

I think we should probably treat the `AA` change as a separate patch, with an AA only test as well, perhaps `llvm/test/Analysis/BasicAA/libfuncs.ll`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101440/new/

https://reviews.llvm.org/D101440