[PATCH] D101304: AMDGPU/llvm-readobj: Add missing tests for note parsing/displaying

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 28 06:40:41 PDT 2021


jhenderson added a comment.

Just one nit, otherwise looks good, assuming all the tests are passing etc.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-amd-invalid-v2.test:1-2
+# This test is checking the handling of invalid/malformed note entries for
+# AMDGPU code object v2.
+
----------------
Most new llvm-readobj tests use `##` for comments, to help them stand out from lit and FileCheck directives. Same goes with your other comments in this and other tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101304/new/

https://reviews.llvm.org/D101304



More information about the llvm-commits mailing list