[PATCH] D101228: [InlineCost] CallAnalyzer: use TTI info for extractvalue - they are free (PR50099)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:1782
+  // SROA can't look through these, but they may be free.
+  return visitInstruction(I);
 }
----------------
aeubanks wrote:
> I think `Base::visitExtractValue()` is the proper way
Well, then all the code that uses this "proper way" is likely broken,
and either doesn't have test coverage,
or the test changes weren't analyzed well enough.

Because then we don't fall back to `CallAnalyzer::visitInstruction()`,
and don't consider it as zero-cost as per costmodel...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101228/new/

https://reviews.llvm.org/D101228