[PATCH] D101353: [DebugInfo] do not add pc value if lsda value in fde is 0

Wed Apr 28 05:04:42 PDT 2021

dongAxis1944 added a comment.

In D101353#2719773 <https://reviews.llvm.org/D101353#2719773>, @probinson wrote:

> A test plan of `check-llvm` is not sufficient.  It shows that you didn't break anything that we have an existing test for, but it would also suggest that there is no test for this case, and you want that so someone else doesn't break your change in the future.

@probinson thanks for reviewing!
Since the current LLVM code does not handle DW_EH_PE_pcrel well, because the EHFrameAddress is always 0.
But considering the code <https://github.com/facebookincubator/BOLT/blob/rebased/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp#L852> from the bolt, EHFrameAddress is not 0.

I will upload the more ut for this case.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101353/new/

https://reviews.llvm.org/D101353