[PATCH] D100684: [X86][CostModel] X86TTIImpl::getMemoryOpCost(): rewrite vector handling again

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:3238
+  // Handle the simple case of non-vectors.
+  // NOTE: this assumes that legalizatio never creates vector from scalars!
+  if (!VTy || !LT.second.isVector())
----------------
`legalization`


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:3260
+  int NumEltRemaining = SrcNumElt;
+  auto NumEltDone = [&]() { return SrcNumElt - NumEltRemaining; };
+
----------------
Can be `[=]`


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:3293
+
+    assert(CurrVecTy->getNumElements() % CurrNumEltPerOp == 0 && "???");
+    auto *CoalescedVecTy =
----------------
Assert message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100684/new/

https://reviews.llvm.org/D100684