[PATCH] D99599: [NewPM] Add an option to dump pass structure

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added inline comments.


================
Comment at: llvm/include/llvm/IR/PassManagerImpl.h:77
 
-    PI.runAfterAnalysis(P, IR);
+    if (ID != PassInstrumentationAnalysis::ID())
+      PI.runAfterAnalysis(P, IR);
----------------
tejohnson wrote:
> What is this check needed for?
For runBeforeAnalysis and runAfterAnalysis to be in sync. See if block above:
```
if (ID != PassInstrumentationAnalysis::ID()) {
      PI = getResult<PassInstrumentationAnalysis>(IR, ExtraArgs...);
      PI.runBeforeAnalysis(P, IR);
}
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99599/new/

https://reviews.llvm.org/D99599