[llvm] be935f2 - [NFC][Verifier] Fixup token PHINode test cases

[Roman Lebedev via llvm-commits]

Thanks!

Ugh, i was afraid that would happen.
It needs to be duplicated into two files then, with-asserts and without-asserts.

Roman

On Wed, Apr 28, 2021 at 10:59 AM Hans Wennborg <hans at chromium.org> wrote:
>
> I've made the test require asserts in
> e9fe387ac55c2ae79f2cfd4706129fd90c9303a4 for now.
>
> On Wed, Apr 28, 2021 at 1:17 AM Jordan Rupprecht via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> > Looks like this causes failures in release builds. I don't have a buildbot link yet; I noticed this running tests locally. Reproduced directly:
> >
> > $ bin/llvm-as ~/src/llvm-project/llvm/test/Verifier/token1.ll -o /dev/null
> > bin/llvm-as: assembly parsed, but does not verify as correct!
> > Function takes token but isn't an intrinsic
> > token %A
> > void (token, token)* @f
> > PHI nodes cannot have token type!
> >
> > $ echo $?
> > 1
> >
> > I guess it's not actually crashing, just returning a bad error code.
> >
> > On Tue, Apr 27, 2021 at 1:10 PM Roman Lebedev via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> >>
> >>
> >> Author: Roman Lebedev
> >> Date: 2021-04-27T21:09:43+03:00
> >> New Revision: be935f28888cbfe705699fa3beb8b849aa0f9f90
> >>
> >> URL: https://github.com/llvm/llvm-project/commit/be935f28888cbfe705699fa3beb8b849aa0f9f90
> >> DIFF: https://github.com/llvm/llvm-project/commit/be935f28888cbfe705699fa3beb8b849aa0f9f90.diff
> >>
> >> LOG: [NFC][Verifier] Fixup token PHINode test cases
> >>
> >> It would still pass in non-assert build,
> >> but with asserts it would now crash.
> >>
> >> I haven't checked, but hopefully `not`'s `--crash` argument
> >> should be enough to support both paths.
> >>
> >> Added:
> >>
> >>
> >> Modified:
> >>     llvm/test/Verifier/token1.ll
> >>
> >> Removed:
> >>
> >>
> >>
> >> ################################################################################
> >> diff  --git a/llvm/test/Verifier/token1.ll b/llvm/test/Verifier/token1.ll
> >> index ac7ff30948ea..90d48832f2bb 100644
> >> --- a/llvm/test/Verifier/token1.ll
> >> +++ b/llvm/test/Verifier/token1.ll
> >> @@ -1,4 +1,4 @@
> >> -; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
> >> +; RUN: not --crash llvm-as %s -o /dev/null 2>&1 | FileCheck %s
> >>
> >>  define void @f(token %A, token %B) {
> >>  entry:
> >>
> >>
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at lists.llvm.org
> >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits