[PATCH] D101395: [lld-macho] Implement builtin section renaming

Tue Apr 27 19:23:42 PDT 2021

gkm added inline comments.

================
Comment at: lld/MachO/MergedOutputSection.cpp:59-61
+    error("Cannot add merge section; inconsistent type: old=0x" +
+          llvm::to_hexString(SECTION_TYPE & flags) + ", new=0x" +
+          llvm::to_hexString(sectionFlag));
----------------
gkm wrote:
> This has no test. It feels like overkill to make a testcase for it. This is a bug fix discovered during testing section renames. The old message appeared as ...
> ```
> Cannot add merge section; inconsistent type flags ^@
> ```
> Where the section type was a raw NUL (0) byte, and clearly wrong.
After adding section names to the diagnostic message, I went ahead and added a test case. ;)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101395/new/

https://reviews.llvm.org/D101395