[PATCH] D78778: [AsmPrinter] Fix emitting CFI for debug when exceptions are not supported

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 13:12:57 PDT 2021


MaskRay added a comment.

I was confused by the subject (this is new support, not fixing a bug). The updated wasm tests contradict "while maintaining the status quo on how the other things were."
Also, I think the summary may be easier to understand if you just state in the beginning that this allows `ExceptionHandling::None` to use `.debug_frame`.
You can then explain some concepts, if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78778/new/

https://reviews.llvm.org/D78778



More information about the llvm-commits mailing list