[PATCH] D100575: [flang][OpenMP][FIX] Fix the worksharing nesting check with inclusion of more constructs to cover entire workshare family.

[Arnamoy B via Phabricator via llvm-commits]

arnamoy10 added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.h:45
 static OmpDirectiveSet doSet{Directive::OMPD_distribute_parallel_do,
     Directive::OMPD_distribute_parallel_do_simd, Directive::OMPD_parallel,
     Directive::OMPD_parallel_do, Directive::OMPD_parallel_do_simd,
----------------
kiranchandramohan wrote:
> Not sure why parallel is here. Remove if no test fails.
Done, thanks


================
Comment at: flang/lib/Semantics/check-omp-structure.h:71-75
+    llvm::omp::Directive::OMPD_workshare,
+    Directive::OMPD_parallel_workshare,
+    Directive::OMPD_parallel_sections,
+    llvm::omp::Directive::OMPD_sections,
+    llvm::omp::Directive::OMPD_single,
----------------
kiranchandramohan wrote:
> Why do a few of these have the llvm::omp prefix but others do not?
typo, thanks for the catch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100575/new/

https://reviews.llvm.org/D100575