[PATCH] D101290: [LV] Try to sink and hoist inside candidate loops for vectorization.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I find it pretty odd that LoopVectorize would have this kind of side effect on code that's not vectorized. I don't think that's really the same as construction of LoopSimplify/LCSSA form, which is pretty much par the course for any loop pass. D84108 <https://reviews.llvm.org/D84108> mentions that:

> I'm proposing to harmonize this, and disable common code hoisting until late
> in pipeline. Definition of late may vary, currently i've picked the same one
> as for code sinking, but i suppose we could enable it as soon as right after
> loop rotation happens.

I think that doing that (enabling hoisting in some post-LoopRotate SimplifyCFG run) would be cleaner than having it happen as a side-effect of LoopVectorize.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101290/new/

https://reviews.llvm.org/D101290