[PATCH] D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: JDevlieghere.
dblaikie added a comment.

In D101373#2720592 <https://reviews.llvm.org/D101373#2720592>, @StephenTozer wrote:

> In D101373#2720575 <https://reviews.llvm.org/D101373#2720575>, @dblaikie wrote:
>
>> Hmm - not sure I follow. The LLVM IR for the reproduce @rupprecht gave seems to be about half that (~460 lines) - in any case, one workaround could be to include a test-only flag for the limit and set the limit artificially low for testing.
>
> Yeah, I was just planning on producing a test case that starts as late in the pipeline as possible; the MIR prior to beginning register allocation is 977 lines, from a 351 line LLVM IR file. If it's better to use the IR file for this (which may be reasonable given the size difference), then that simplifies things - although it can still probably be reduced further. If that doesn't work, then using a test flag might be the way to go.

Ah, right - I haven't dabbled much with the MIR test cases, I can see how that easily doubles the size of the test, etc. I'd personally be OK with a plain IR case for something like this, perhaps. (@aprantl @JDevlieghere any thoughts on this?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101373/new/

https://reviews.llvm.org/D101373