[llvm] 12011b5 - [AMDGPU] GCNHazardRecognizer: ignore all meta instructions

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 12:17:22 PDT 2021


Author: Jay Foad
Date: 2021-04-27T20:17:15+01:00
New Revision: 12011b5217929ef8a56c2099c6f3233934ea4fbc

URL: https://github.com/llvm/llvm-project/commit/12011b5217929ef8a56c2099c6f3233934ea4fbc
DIFF: https://github.com/llvm/llvm-project/commit/12011b5217929ef8a56c2099c6f3233934ea4fbc.diff

LOG: [AMDGPU] GCNHazardRecognizer: ignore all meta instructions

This is hopefully NFC, but should be more robust in ignoring all
instructions that should be ignored, instead of just some of them.

Differential Revision: https://reviews.llvm.org/D101372

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
index f5db222fc05b..82e1c58210b2 100644
--- a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
@@ -348,8 +348,7 @@ void GCNHazardRecognizer::AdvanceCycle() {
   // Do not track non-instructions which do not affect the wait states.
   // If included, these instructions can lead to buffer overflow such that
   // detectable hazards are missed.
-  if (CurrCycleInstr->isImplicitDef() || CurrCycleInstr->isDebugInstr() ||
-      CurrCycleInstr->isKill()) {
+  if (CurrCycleInstr->isMetaInstruction()) {
     CurrCycleInstr = nullptr;
     return;
   }


        


More information about the llvm-commits mailing list