[PATCH] D101380: [AMDGPU] Move insertion of function entry waitcnt later

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 11:30:01 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1599
   BlockInfos.clear();
+  bool Modified = true;
+
----------------
Modified = false;?


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1606
+
+    // TODO: Could insert earlier and schedule more liberally with operations
+    // that only use caller preserved registers.
----------------
Is this comment still relevant?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101380/new/

https://reviews.llvm.org/D101380



More information about the llvm-commits mailing list