[PATCH] D100490: [ELF] Check the Elf_Rel addends for dynamic relocations
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 27 11:19:36 PDT 2021
MaskRay added a comment.
In D100490#2711781 <https://reviews.llvm.org/D100490#2711781>, @arichardson wrote:
> Maybe `OutputSection::checkDynRelAddends()` should be moved to a separate patch and this one just does the DynamicReloc refactoring that fixes `ppc64-abs64-dyn.s` and `got32-i386-pie-rw.s` with `-z rela`.
> @MaskRay would that make reviewing the patch easier?
I am still unclear that we want to do `OutputSection::checkDynRelAddends()` unconditionally. It is probably a good addition for LLVM_ENABLE_ASSERTIONS=on builds.
The improvement bits should definitely be separate from the check bits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100490/new/
https://reviews.llvm.org/D100490
More information about the llvm-commits
mailing list