[PATCH] D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

This presumably needs a test case.

But also: The DWARF we're generating here is pretty heinous - is the intent that this is a short term fix, but some attempt to reign in these /massive/ expressions is on your/someone's TODO list?

Hmm, I guess maybe the DWARF expression size isn't the fault of the DWARF location generation itself, instead maybe it's a function of some weird/bad codegen? We're spilling all these values to the stack even at -O3? 248 byte stack frame for this function?



================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:147
+            FragmentInfoOpt->SizeInBits);
       LocNos.reset(new unsigned[LocNoCount]());
+      LocNos[0] = UndefLocNo;
----------------
make_unique, perhaps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101373/new/

https://reviews.llvm.org/D101373