[PATCH] D101381: [ELF][MIPS] Emit dynamic relocations for PIC non-preemptible static TLS

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:1004
+      // be allocated before us in the static TLS block.
+      if (s->isPreemptible || config->isPic)
         mainPart->relaDyn->addReloc(target->tlsGotRel, this, offset, s);
----------------
(Caveat: I know really little/nothing about mips)

`if (s->isPreemptible || config->shared)`?

For other targets, -pie don't need a dynamic relocation. See `bool isLocalInExecutable = !sym.isPreemptible && !config->shared;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101381/new/

https://reviews.llvm.org/D101381