[PATCH] D101304: AMDGPU/llvm-readobj: Add missing tests for note parsing/displaying

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 10:02:22 PDT 2021


kzhuravl marked 7 inline comments as done.
kzhuravl added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-amd-invalid-v3.s:30
+    Type:     SHT_NOTE
+    Content:     07000000D400000020000000414D44475055000081ae616d646873612e6b65726e656c73918ab92e67726f75705f7365676d656e745f66697865645f73697a6502b62e6b65726e6172675f7365676d656e745f616c69676e04b52e6b65726e6172675f7365676d656e745f73697a6501b82e6d61785f666c61745f776f726b67726f75705f73697a6508a52e6e616d65a3666f6fbb2e707269766174655f7365676d656e745f66697865645f73697a6503ab2e736770725f636f756e7406a72e73796d626f6ca3666f6fab2e766770725f636f756e7407af2e7761766566726f6e745f73697a6505
----------------
jhenderson wrote:
> Is this the minimum the data can be in order to trigger the code path you are testing here?
I have trimmed it to the minimum.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101304/new/

https://reviews.llvm.org/D101304



More information about the llvm-commits mailing list