[PATCH] D101330: [flang] Handle structure constructors with forward references to PDTs

[Peter Klausler via Phabricator via llvm-commits]

klausler accepted this revision.
klausler added a comment.
This revision is now accepted and ready to land.

Looks great apart from my naming nit.



================
Comment at: flang/include/flang/Semantics/expression.h:385
   }
+  bool IsBadForwardReference(const semantics::DerivedTypeSpec &);
 
----------------
Since this member function can emit a Message, it's not just a predicate; a name with "Check" would be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101330/new/

https://reviews.llvm.org/D101330