[PATCH] D100281: [AMDGPU] Revise handling of preexisting waitcnt

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 09:36:57 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:814
+       &*II != MI; II = NextI, ++NextI) {
+    if (II->isDebugInstr())
+      continue;
----------------
kerbowa wrote:
> rampitec wrote:
> > isMetaInstruction() probably?
> thanks.
Can you add a test for kill being ignored? Those keep showing up as a problem


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100281/new/

https://reviews.llvm.org/D100281



More information about the llvm-commits mailing list