[PATCH] D101302: [AArch64][SVE] Move convert.{from,to}.svbool optimization into InstCombine

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Thanks for doing this! I think instcombine will be OK with altering the phi's and the walk like this.
It's a little simpler in MVE, as we end up converting predicates to/from i16, and just merge adjacent convert.to/convert.from.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:288
+                                              IntrinsicInst &II) {
+  SmallVector<Instruction *, 32> Worklist;
+  auto RequiredType = II.getType();
----------------
Worklist isn't used, I don't think.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:289
+  SmallVector<Instruction *, 32> Worklist;
+  auto RequiredType = II.getType();
+
----------------
auto *
(And maybe just Type *)


================
Comment at: llvm/test/Transforms/InstCombine/AArch64/sve-intrinsic-opts-reinterpret.ll:262
+
+attributes #0 = { "target-features"="+sve" }
----------------
Is this used? It may work fine without, and I don't see #0 used anywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101302/new/

https://reviews.llvm.org/D101302