[PATCH] D101261: [flang] Lift -Werror checks into local functions

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Really nice to see this refactor, thank you!

In D101261#2715404 <https://reviews.llvm.org/D101261#2715404>, @ashermancinelli wrote:

> Notice that in `PrescanAndSemaAction`, the first check fails with a scanning error, and the second with a parsing error. This is not the case for `PrescanAndParseAction`, which makes me think the second check should fail with a parsing error, and the tests should be adjusted in the same way.

I agree with you. Could you update it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101261/new/

https://reviews.llvm.org/D101261