[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/logical-select.ll:385
+; CHECK-NEXT:    [[OR:%.*]] = select i1 [[AND1]], i1 true, i1 [[AND2]]
+; CHECK-NEXT:    ret i1 [[OR]]
 ;
----------------
aqjune wrote:
> nikic wrote:
> > It looks like this fold could be salvaged, if we wanted to: https://alive2.llvm.org/ce/z/TpsYAj
> Thx, I added the transformation.
> If the transformations look good, I'll make it as a separate commit with tests and push it.
Could you please split it off into a separate review? Hard to understand impact as part of this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101191/new/

https://reviews.llvm.org/D101191