[PATCH] D101297: [SLP]Allow masked gathers only if allowed by target.

Tue Apr 27 07:21:12 PDT 2021

ABataev added a comment.

In D101297#2719675 <https://reviews.llvm.org/D101297#2719675>, @anton-afanasyev wrote:

>>> I believe it will work correct after lowering fixes. I'm still investigating this case https://bugs.llvm.org/show_bug.cgi?id=50015, this is definitly lowering issue since llvm code looks correct.
>>> Ok, I think this patch is good temp solution until miscompile issue isn't solved.
>>
>> Maybe better to rework it and land it in X86TargetTransfromInfo.cpp for better cost modelling if it is not legal directly?
>
> Yes, I believe this will fix PR50015, though it doesn't fix the whole problem related to lowering.

No, I don't think it will fix PR50015, it may hide it in some cases, yes. My main goal is to improve vectorization in general. Ok, I will rework it and land it in in a cost model for masked gathers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101297/new/

https://reviews.llvm.org/D101297