[PATCH] D101076: [SVE][LoopVectorize] Add support for scalable vectorization of first-order recurrences

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/first-order-recurrence.ll:120
+; CHECK: %[[SUB1:.*]] = sub i32 %[[MUL1]], 1
+; CHECK: %vector.recur.init = insertelement <vscale x 4 x i16> poison, i16 %0, i32 %[[SUB1]]
+; CHECK: vector.body:
----------------
david-arm wrote:
> nit: Perhaps better to use a named variables in this test instead of `%vector.recur.init` and `%vector.recur` as they chould change?
@david-arm I think this is typical behaviour, as used by the original tests. These names are hardcoded within the pass so can be relied upon.  If nothing else, relying on these names means we can ensure the IR remains readable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101076/new/

https://reviews.llvm.org/D101076