[PATCH] D101308: [SystemZ][z/OS] Remove register prefixes when printing out the register.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 05:47:26 PDT 2021


uweigand accepted this revision.
uweigand added a comment.

LGTM as well.



================
Comment at: llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinter.cpp:59
 
+void SystemZInstPrinter::printFormattedRegName(const MCAsmInfo *MAI,
+                                               unsigned RegNo, raw_ostream &O) {
----------------
abhina.sreeskantharajan wrote:
> minor comment: Could we just pass in the AssemblerDialect instead of the MAI object because it seems to be the only thing being used? If there are future changes coming that use MAI, then feel free to ignore.
I actually prefer passing the MAI, this is more general and done everywhere else as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101308/new/

https://reviews.llvm.org/D101308



More information about the llvm-commits mailing list