[PATCH] D101287: [SimplifyCFG] Expose sinking and hoisting helpers.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 05:02:13 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/Local.h:186
+bool hoistThenElseCodeToIf(BranchInst *BI, const TargetTransformInfo &TTI,
+                           bool EqTermsOnly, DomTreeUpdater *DTU);
+
----------------
fhahn wrote:
> RKSimon wrote:
> > Do we need DTU? 
> Yes I think so. I think the function may have to update the DT, in case the terminators are hoisted (around llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1617)
OK, if you're intending to make use of it in an upcoming patch that's fine - I didn't see it being put to use in D101290 though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101287/new/

https://reviews.llvm.org/D101287



More information about the llvm-commits mailing list