[PATCH] D101354: Remove unimplemented interfaces for Character[Min|Max][Val|Loc]. NFC

[Diana Picus via Phabricator via llvm-commits]

rovka created this revision.
rovka added reviewers: klausler, tskeith.
rovka requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

MAXVAL, MINVAL, MAXLOC and MINLOC are already implemented in extrema.cpp
as MaxvalCharacter, MinvalDim etc. Therefore, the interfaces in
character.h are redundant and should be removed to avoid confusion.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101354

Files:
  flang/runtime/character.cpp
  flang/runtime/character.h


Index: flang/runtime/character.h
===================================================================
--- flang/runtime/character.h
+++ flang/runtime/character.h
@@ -105,18 +105,6 @@
     const char *sourceFile = nullptr, int sourceLine = 0);
 void RTNAME(CharacterMin)(Descriptor &accumulator, const Descriptor &x,
     const char *sourceFile = nullptr, int sourceLine = 0);
-void RTNAME(CharacterMaxVal)(Descriptor &result, const Descriptor &x,
-    int dim = 0, const Descriptor *mask = nullptr,
-    const char *sourceFile = nullptr, int sourceLine = 0);
-void RTNAME(CharacterMinVal)(Descriptor &result, const Descriptor &x,
-    int dim = 0, const Descriptor *mask = nullptr,
-    const char *sourceFile = nullptr, int sourceLine = 0);
-void RTNAME(CharacterMaxLoc)(Descriptor &result, const Descriptor &x,
-    int dim = 0, const Descriptor *mask = nullptr, int kind = sizeof(int),
-    bool back = false, const char *sourceFile = nullptr, int sourceLine = 0);
-void RTNAME(CharacterMinLoc)(Descriptor &result, const Descriptor &x,
-    int dim = 0, const Descriptor *mask = nullptr, int kind = sizeof(int),
-    bool back = false, const char *sourceFile = nullptr, int sourceLine = 0);
 
 std::size_t RTNAME(Index1)(const char *, std::size_t, const char *substring,
     std::size_t, bool back = false);
Index: flang/runtime/character.cpp
===================================================================
--- flang/runtime/character.cpp
+++ flang/runtime/character.cpp
@@ -1024,8 +1024,5 @@
     const char *sourceFile, int sourceLine) {
   MaxMin<true>(accumulator, x, sourceFile, sourceLine);
 }
-
-// TODO: Character MAXVAL/MINVAL
-// TODO: Character MAXLOC/MINLOC
 }
 } // namespace Fortran::runtime


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101354.340791.patch
Type: text/x-patch
Size: 1713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210427/d5a1e620/attachment.bin>