[PATCH] D101196: [SCEV] Handle uge/ugt predicates in applyLoopGuards()

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 03:33:54 PDT 2021


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

Would it be possible to have a test which requires multiple re-writes, by limiting the IV in both directions?



================
Comment at: llvm/test/Analysis/ScalarEvolution/max-backedge-taken-count-guard-info.ll:636
   %shr = lshr i32 %blockSize, 2
   %guard = icmp ult i32 %blockSize, 4
   br i1 %guard, label %while.end, label %while.body.preheader
----------------
IMO it would slightly increase the readability of the test here if we would use the `uge` predicate, as in the test name :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101196/new/

https://reviews.llvm.org/D101196



More information about the llvm-commits mailing list