[PATCH] D101174: [IRCE] Relieve bound check on isSafeIncreasingBound and isSafeDecreasingBound

Tue Apr 27 03:29:02 PDT 2021

lebedev.ri added a comment.

In D101174#2719140 <https://reviews.llvm.org/D101174#2719140>, @jaykang10 wrote:

> In D101174#2719038 <https://reviews.llvm.org/D101174#2719038>, @lebedev.ri wrote:
>
>> Won't this regress old-pm, or break again if/when new-pm is switched to populate loops in the other direction?
>
> IRCE pass has not been enabled in the pipeline of old-pm and new-pm.

Yes, i know.

> The previous bound check was ok but it was a bit too conservative and it blocked for IRCE pass to handle loops which can be handled by the pass.
> The population order of loops affects SCEV and the SCEV blocks the IRCE pass. I think this change is fine.

I think you didn't answer the question though.

> As next step, I will start to discussion to enable IRCE pass in the pipeline of new-pm.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101174/new/

https://reviews.llvm.org/D101174