[PATCH] D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

In D91722#2717356 <https://reviews.llvm.org/D91722#2717356>, @rupprecht wrote:

> I'm seeing a crash after the most recent time this was re-applied in 791930d74087b8ae8901172861a0fd21a211e436 <https://reviews.llvm.org/rG791930d74087b8ae8901172861a0fd21a211e436>. The crash is when compiling https://github.com/beltoforion/muparser/blob/master/src/muParserTest.cpp, but I'm reducing it now, as the error might also depend on how we build that internally (we use at least`-g -O3`)

Thanks for the report, and the handy reproducer! I'll upload a fix momentarily; we didn't expect to actually hit the capacity limit, but now that we know it's entirely possible to do so I'll either remove the assert and make sure the debug value is dropped instead, or expand the capacity limit. The latter would be preferred, but could cause performance issues with the current implementation of LiveDebugVariables; once I've determined whether or not anything will break from doing so, I'll push up the appropriate fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91722/new/

https://reviews.llvm.org/D91722