[PATCH] D101174: [IRCE] Relieve bound check on isSafeIncreasingBound and isSafeDecreasingBound

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added inline comments.


================
Comment at: llvm/test/Transforms/IRCE/variable-loop-bounds.ll:362
+
+define void @test_dec_bound(i64 %0, i64 %1) {
+  br label %3
----------------
fhahn wrote:
> Also, should we have tests checking the actual IR, at least the important bits like most other test do here?
Yep, I will update it.


================
Comment at: llvm/test/Transforms/IRCE/variable-loop-bounds.ll:370
+
+6:                                                ; preds = %3
+  br label %7
----------------
fhahn wrote:
> I personally find tests with a lot of numbered BBs and instructions quite hard to read. IMO it would improve readability & maintainability of those tests if the blocks and instructions would have descriptive labels :)
Yep, I will update it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101174/new/

https://reviews.llvm.org/D101174