[PATCH] D98509: [LV] Calculate max feasible scalable VF.

Tue Apr 27 01:40:24 PDT 2021

fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks for the updates!

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1626
+  /// limited to MaxVF. This is a helper function of computeFeasibleMaxVF.
+  ElementCount getMaxVectorElementCount(unsigned ConstTripCount,
+                                        unsigned SmallestType,
----------------
sdesmalen wrote:
> fhahn wrote:
> > The other related functions refer to VF instead of element count in their name. Is there a reason to use ElementCount instead of VF here? Perhaps the name could be made a bit more descriptive in general, including the fact that the function computes the max VF based on target-specific properties? 
> You're right that using VF is probably better/more consistent, I mostly chose ElementCount so not to avoid it with other MaxVF-related functions. I've now changed it to `getMaximizedVFForTarget`, does that make sense to you?
> 
> I've chosen the term 'Maximized' instead of 'Max' to distinguish it from 'Maximum', as in:
> The LV tries to //Maximize// the VF based on the target's register width, but with a //Maximum// of `MaxSafeVF`.
Sounds good to me, but I am no expert of the English language :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98509/new/

https://reviews.llvm.org/D98509