[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

[Paulo Matos via Phabricator via llvm-commits]

pmatos added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrMemory.td:120
+// Global GET
+def wasm_global_get_t : SDTypeProfile<1, 1, [SDTCisPtrTy<1>]>;
+def wasm_global_get : SDNode<"WebAssemblyISD::GLOBAL_GET", wasm_global_get_t,
----------------
sbc100 wrote:
> The other names in this file seem to either use UPPER_SNAKE_CASE or CamelCase.   Any reason these new one use lower_snake_case?
@sbc100 I think it's quite mixed in this file at least. In the beginning of the file we have `def regPlusImm` followed by `def or_is_add`.  These are for `PatFrag`s. I modelled these after @tlively 's SIMD `SDTypeProfile` that uses: `def wasm_load_splat_t` for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95425/new/

https://reviews.llvm.org/D95425