[PATCH] D101280: [XCOFF] string constants handling for XCOFF

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 21:56:07 PDT 2021


shchenz added a comment.

Thanks for your review @hubert.reinterpretcast



================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:63-68
+  void PrintQuotedString(StringRef Data, raw_ostream &OS);
+  void printDwarfFileDirective(unsigned FileNo, StringRef Directory,
+                               StringRef Filename,
+                               Optional<MD5::MD5Result> Checksum,
+                               Optional<StringRef> Source,
+                               bool UseDwarfDirectory, raw_svector_ostream &OS);
----------------
hubert.reinterpretcast wrote:
> New member functions can be `const`?
Good idea


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101280/new/

https://reviews.llvm.org/D101280



More information about the llvm-commits mailing list