[PATCH] D99157: [XCore][Test] inline asm memory constraint not supported.

[Eric Christopher via llvm-commits]

On Wed, Apr 21, 2021 at 10:58 AM Nigel Perks via Phabricator <
reviews at reviews.llvm.org> wrote:

> nigelp-xmos added a comment.
>
> @echristo Thanks for the comment, Eric. I'm happy to do what is expected.
> Do you mean that it's a bug not to accept these cases, and we should fix it
> rather than XFAIL? So the build should not be green from XFAIL but only
> from a fix in this case?
>

If they're failing anyhow you can xfail them, but not having any context
this looks like it's assumed to not work for a reason other than "the port
doesn't work". I'm not sure how to prioritize making the build green here -
if it's a recent regression that's going to be fixed imminently that's one
thing, if it's a long term xfail that's something else. Either way it
probably needs comments and a descriptive commit message :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210426/e9f485bc/attachment.html>