[PATCH] D101280: [XCOFF] string constants handling for XCOFF

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with comments.



================
Comment at: llvm/include/llvm/MC/MCAsmInfo.h:348-349
 
+  /// Tue if the target represents string constant as mostly raw characters in
+  /// paired double quotation. Default to false.
+  bool HasPairedDoubleQuoteStringConstants = false;
----------------
Suggested expanded description here.


================
Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:25
+  // For XCOFF, string constant consists of any number of characters enclosed in
+  // "" (double quotation marks)
+  HasPairedDoubleQuoteStringConstants = true;
----------------
Add period to the end of the sentence.


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:63-68
+  void PrintQuotedString(StringRef Data, raw_ostream &OS);
+  void printDwarfFileDirective(unsigned FileNo, StringRef Directory,
+                               StringRef Filename,
+                               Optional<MD5::MD5Result> Checksum,
+                               Optional<StringRef> Source,
+                               bool UseDwarfDirectory, raw_svector_ostream &OS);
----------------
New member functions can be `const`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101280/new/

https://reviews.llvm.org/D101280